Closed nautaa closed 4 months ago
Thanks for the PR! However, even though we can undefine strdup
it also means we won't override it generally since most other files will use the define'd strdup. (in this case it is fine for #885 since that uses calloc/malloc internally though).
Maybe it is better to check if strdup
is a #define
and just not override in that case?
I think I will do this instead unless I missed something?
close #885