search

microsoft / mimalloc

mimalloc is a compact general purpose allocator with excellent performance.
MIT License
9.74k stars 791 forks source link

fix proposal for malloc_size/malloc_good_size symbol exports. #901

Closed devnexen closed 1 month ago

devnexen commented 1 month ago

close #900

daanx commented 1 month ago

Thanks @devnexen ! However, I don't think this is quite right -- on macOS with MI_OSX_IS_INTERPOSED we don't want to override malloc_size as that is part of the zone interface, but otherwise bota malloc_size and malloc_good_size should be defined (right?). I thing issue #900 is just about including a declaration in a header file (mimalloc_override.h) in cases where the code uses malloc_good_size but it is not declared in any header file (and we like to use the mimalloc definition).

devnexen commented 1 month ago

But I get the same issue with malloc_size which is defined already. At some point, perl configure asks you about nm, which seems to indicate it is not necessarily looking at headers.