[Do not merge till VS integration]Add probes to todo app

microsoft / mindaro

Bridge to Kubernetes - for Visual Studio and Visual Studio Code

MIT License

307 stars 106 forks source link

[Do not merge till VS integration]Add probes to todo app #154

Closed pragyamehta closed 3 years ago

daniv-msft commented 3 years ago

Could you please not check in this PR until Visual Studio ships our latest version (should be in ~7-10 days)? Else, it will break the Visual Studio quickstart now that it relies on the TODO app (https://docs.microsoft.com/en-us/visualstudio/containers/bridge-to-kubernetes?view=vs-2019).

daniv-msft commented 3 years ago

@pragyamehta The Visual Studio partner team released their new versions a couple of weeks ago. It should be the same version as the one we currently have in prod in VS Code. Could you please validate the sample works with the latest VS version and check in this PR before we forget?

pragyamehta commented 3 years ago

@daniv-msft It's funny that this PR is open, because I remember checking in this change sometime back after you told me to go ahead and check it in. Anyway, this is already checked in, so abandoning this PR.