search

microsoft / mindaro

Bridge to Kubernetes - for Visual Studio and Visual Studio Code
MIT License
307 stars 106 forks source link

On B2K shutdown targetPort in SVC not restored properly #159

Open Retna-Gjensidige opened 3 years ago

Retna-Gjensidige commented 3 years ago

Describe the bug When the value for a targetPort in a Service is a name/string and not a number, B2K changes it to the actual mapped port. e.g. targetPort: http -> is changed to targetPort: 3000 When B2K is shutdown, the targetPort is still 3000, but should be http when everything else is restored on shutdown.

To Reproduce Steps to follow to reproduce this issue. In a kubernetes service, for targetPort, use the mapped ports name instead of port number.

Expected behavior On shutdown everything is restored to as it was. The cloned svc is correct, the data is there for full restore to be successfull.

Environment Details Client used (VS Code/Visual Studio): VS Code AKS cluster: v1.19.6

Additional context We are using ArgoCD to manage deployments. When the svc is not restored, we get an out of sync flag and that's how we noticed this bug.

lolodi commented 3 years ago

Hi @Retna-Gjensidige, Thanks for reporting this issue. It is definitely an interesting one! I added it to our backlog and we'll get back here once the fix is shipped.