microsoft / mindaro

Bridge to Kubernetes - for Visual Studio and Visual Studio Code
MIT License
307 stars 106 forks source link

Restore job deployment - kubectl timeout after 3000ms #194

Closed tigerquoll closed 3 years ago

tigerquoll commented 3 years ago

Describe the bug When deploying non-isolated deployment on a busy cluster we get:

Failed to deploy remote restore job for pod deployment 'test/test-pod' with error: 'kubectl' timeout after 3000ms when running --kubeconfig="/var/folders/pv/d8mtpsh9493dfrbq4p28jysr0000gn/T/tmp6ZodWz.tmp" delete job,secret -n test -l mindaro.io/instance=f38de26aa9

Is it possible to configure timeout to something other than 3 seconds?

To Reproduce Launch on busy cluster.

**Expected behavior** Option for a longer timeout **Logs** [bridge-mindarocli-2021-06-23-11-24-44-76571.txt](https://github.com/microsoft/mindaro/files/6701421/bridge-mindarocli-2021-06-23-11-24-44-76571.txt) [bridge-library-2021-06-23-11-24-45-76571.txt](https://github.com/microsoft/mindaro/files/6701423/bridge-library-2021-06-23-11-24-45-76571.txt) **Environment Details** Client's version: mindaro.mindaro@1.0.120210615 VSCode/1.0.120210615" Operating System: macos **Additional context** Add any other outputs from the clients or context you would like to share.
lolodi commented 3 years ago

Hi @tigerquoll, thanks for reporting this issue. It makes sense to use longer timeout, I logged a work item on our board and I'll let you know here when a fix is ready.

tigerquoll commented 3 years ago

@lolodi thank you for your consideration. I'm eager to try out this product, but the bridge constantly times out when trying to connect to our cluster - I can see the deployment just beginning to start just before the timeout. Any idea on timeframe at all?

lolodi commented 3 years ago

@tigerquoll, the new version with this fix should be completely deployed by the end of this week (July 9).

lolodi commented 3 years ago

@tigerquoll Also, if you'd like, you can use our staging bits that already contain the fix. If you're willing to try beta bits of our VS Code extension, here is how you can test them:

Please note that VS Code easily loses environment variables if you open a new window, so please make sure that you can see the [STAGING] prefix in the Kubernetes status bar item before testing your application.

tigerquoll commented 3 years ago

@lolodi Thank you very much for the code and the instructions. I have the bridge now successfully making connections!

lolodi commented 3 years ago

Excellent! You should see these changes in the normal prod version by end of week, so that you won't need to do all the procedure above. I'll go ahead and close this issue.