microsoft / mindaro

Bridge to Kubernetes - for Visual Studio and Visual Studio Code
MIT License
307 stars 106 forks source link

Configure the default envoy timeout and maybe some other global configurations from outside #197

Open itays-chase opened 3 years ago

itays-chase commented 3 years ago

when trying to debug a flow of services with multiple http hops, I am getting timeouts when the debugging session is not ending within 15 seconds. I understand it is because of this: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-field-config-route-v3-routeaction-timeout which defaults to 15 seconds. Is there an option to give the kubernetes bridge envoy proxy some global configurations from outside? Otherwise it is very limiting to have only 15 seconds to debug before getting a timeout.

Thanks

daniv-msft commented 3 years ago

Thanks @itays-chase for logging this issue! I confirm I'm able to reproduce this when using isolation. There are no configurations available to configure this timeout on our side, but from my perspective this shouldn't be needed as it's a bug we need to fix: users should not have to deal with this kind of complexity unless there is no other way.

We're looking into this more and will let you know if we confirm that this comes from envoy default timeout, and if we have a fix/workaround. As this only happens when isolation is enabled, if you're able to work without it you shouldn't get this bug. I'm not sure if that's a viable option in your case however.

itays-chase commented 3 years ago

Hi @daniv-msft, thanks for the answer! Let me know when the bug is fixed. Anyway, I think it will be nice to have an option to configure the envoy proxy, even if it is just for edge cases when the default configuration doesn't work for you. Until the issue is fixed, I found a workaround by setting this header to a long timeout. https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#config-http-filters-router-x-envoy-upstream-rq-timeout-ms

daniv-msft commented 3 years ago

Thanks @itays-chase! Adding @pragyamehta who is looking into this.