search

microsoft / mixed-reality-extension-sdk

The Mixed Reality Extension SDK enables developers to build 3D world extensions for AltspaceVR, using Node.JS.
MIT License
142 stars 61 forks source link

AltspaceVR: World Editor page for SDK apps should hide URI when using appID #655

Open sorenhan opened 4 years ago

sorenhan commented 4 years ago

The AltspaceVR world editor is currently allowing users to change the URI if an MRE has been created using a registered app. This shouldn't be allowed - if it is a registered app, the appID should be used to look up the URI from ALtspace's app register every time

There are 2 separate changes needed

  1. In the World editor page to change settings on an MRE, if the MRE has an App ID then the world editor should disable the URI editor
  2. During MRE instantiation, if an MRE has an App ID, then the App ID should be used to look up the URI, rather than trust the URI coming in from the space component
stevenvergenz commented 4 years ago

One question mark with this issue (which I agree with in general) is how query arguments should be handled. Some (many?) apps rely on them to be useful.

SorenHannibal commented 4 years ago

good point. Maybe instead of hiding the field it could show mre:12345678?parameters or ws://uri?parameters, depending on if it is using an appid or a uri.

stevenvergenz commented 4 years ago

I don't think we should expose the app ID to the users. Maybe we can make the URL a label instead of a text field, but keep a text field for the query params?

sorenhan commented 4 years ago

Good idea to separate the two. There already is a separate label field for all MREs, so maybe we could separate parameters and URL, and just hide URL field when we have an appID.

tombuMS commented 4 years ago

Agree with Steven on the approach in separating the two.