search

microsoft / mls-excel-app

Microsoft Machine Learning Server Excel Add-in
22 stars 9 forks source link

Updated to use ng2-adal 2.0.0 #3

Closed okhoma closed 6 years ago

okhoma commented 6 years ago

I encountered errors related to ng2-adal/core could not be resolved when setting up a development environment from scratch as described in the readme.

  1. There was a breaking change introduced in https://github.com/sureshchahal/angular2-adal:

    BREAKING CHANGE: Make sure you're importing AdalService like this: import { AdalService } from "ng2-adal/dist/core"

  2. There were other errors in ng2-adal node_modules/@angular modules. Those were resolved after I updated the version of ng2-adal to 2.0.0 released 6 months ago: https://www.npmjs.com/package/ng2-adal?activeTab=versions

The pull request specifies 2.0.0 as expected ng2-adal version and updates import of AdalService as recommended in angular2-adal readme.

msftclas commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: okhoma sign now
You have signed the CLA already but the status is still pending? Let us recheck it.