Closed SIkebe closed 3 months ago
FYI, I published GitHub Pages so that you can review the translated workshop page. https://sikebe.github.io/moaw/workshop/github-copilot/translations/workshop.ja.md?step=0
Thank you! Using language code here is fine.
If the original assets (images/code) were not updated, could you update the links to point to the original one instead of duplicating them inside the /translations/
subfolder?
Using language code here is fine.
Then, should I fix the CONTRIBUTING.md?
If the original assets (images/code) were not updated, could you update the links to point to the original one instead of duplicating them inside the /translations/ subfolder?
When I use relative links, the assets were not displayed and you can't download the assets zip file. So I copied those assets into the /translations/
subfolder.
http://localhost:4200/workshop/github-copilot/translations/workshop.ja.md?step=0
Which url should we use to show the assets on translated page locally and on GitHub Page?
Hi @sinedied Do you have any opinions or advice regarding the above issue?
Hi @SIkebe and thank you for your patience.
You're right it seems there's an issue when using ../assets
, I'll open an issue and fix it as soon as possible.
Keep in mind it may take 1-2 weeks as it's a very busy period, again I thank you for your contribution and patience.
Thank you for confirming! Once the issue is resolved, I'll check that again.
Hi @sinedied , what's the status of the issue?
Thanks for your patience, the fix has been published and you can now reference assets from the parent folder.
@sinedied Thanks! I've confirmed that issue had been fixed, so I removed the duplicated assets.
This PR introduces a Japanese translation for the GitHub Copilot workshop.
There’s one point that needs clarification: For the translated filename, should we use the language code such as
ja
, or the country code likejp
? The CONTRIBUTING.md states:However, I’ve noticed that various documents in this repository suggest using the language code. Could you please confirm which is correct?