microsoft / molskill

Extracting medicinal chemistry intuition via preference machine learning
MIT License
103 stars 9 forks source link

fix: rdkit 2023.03.1 support #12

Closed josejimenezluna closed 1 year ago

josejimenezluna commented 1 year ago

Compatibility with the latest release of rdkit (2023.03.1) has been fixed (also fixes #11) . This problem was caused by to the way that descriptors were being computed - importing all available ones instead of fixing a set of them. A new descriptor AvgIpc was introduced in the last release breaking all expected model shapes with the default model.

Other fixes:

A release will follow after this PR to fix the conda package, which will also be broken for new installations that include the newer rdkit version.

EDIT: For some reason, conda is currently unable to correctly suggest the py39 package for Python 3.9 and instead falls back to py310 unless explicily pointed to a build number. I am fixing this in the README.md for the time being while I look for a solution.