search

microsoft / monaco-editor-webpack-plugin

Moved to https://github.com/microsoft/monaco-editor
483 stars 99 forks source link

bad getWorkerUrl regex #100

Closed wangkechun closed 4 years ago

wangkechun commented 4 years ago

ref: https://github.com/microsoft/monaco-editor-webpack-plugin/blob/v1.8.2/src/index.ts#L200

if publicPath = "//xxx.com/static"
/^(http:)|(https:)|(file:)/.test(publicPath) will false

@alexdima

alexdima commented 4 years ago

@wangkechun Would you be willing to create a PR to fix it?

wangkechun commented 4 years ago

done https://github.com/microsoft/monaco-editor-webpack-plugin/pull/101

alexdima commented 4 years ago

Thank you!