microsoft / monaco-editor

A browser based code editor
https://microsoft.github.io/monaco-editor/
MIT License
39.22k stars 3.52k forks source link

Monaco in Mobile #1365

Closed hemantasapkota closed 1 year ago

hemantasapkota commented 5 years ago

Hi team,

My name is Hemanta, and for the past year I've been working on a project that integrates monaco in react native. The integration was a huge success.

Apps: https://itunes.apple.com/us/app/code-playground/id1452106609 https://itunes.apple.com/us/app/go-playground/id1437518275

I had to make several fixes to the editor to make it work decently inside react native, mostly around scroll view and mouse column computation. I've will submit a PR soon.

How can I attribute the use of the editor in my apps ?

Thanks

donaldpipowitch commented 5 years ago

This sounds really interesting. I'd love to see this. Do you still plan to submit a PR?

k644606347 commented 5 years ago

This sounds great, I hope to use monaco on the mobile side.

jdmunro commented 5 years ago

@hemantasapkota I'd be very interested to see any changes you've made. Also looking for React Native integration. Do you have a fork of the repo somewhere?

karlhorky commented 4 years ago

This would be interesting!

Especially in case it would also handle the ability to long-press -> paste in mobile browsers like Android Chrome!

Steve-Mcl commented 3 years ago

@hemantasapkota what is the chances you could share the changes you made to make this mobile friendly?

Jackman3005 commented 1 year ago

@hemantasapkota Our team is also interested in allowing users to edit code in a RN app. It's been a bit since you originally posted, is the solution you have still working well for you? Anything you're able to share to get others able to use Monaco w/ RN would be awesome!

Jackman3005 commented 1 year ago

Someone on our team knew @hemantasapkota IRL and reached out (small world!). The feedback we got was that Monaco has issues on mobile that make it a poor choice right now. This blog goes into details on that and suggests using CodeMirror which we've now implemented for ourselves and things are working okay for the moment, still not using many of the advanced features yet though.

Not trying to stop people from using Monaco (sorry maintainers!), just want to help people move forward with their goals, hopefully this helps.