search

microsoft / monaco-editor

A browser based code editor
https://microsoft.github.io/monaco-editor/
MIT License
39.78k stars 3.55k forks source link

When we are pressing shortcut key alt+f1 to expand accessibility option no action is performed: #4583

Open AnKushSingh05 opened 2 months ago

AnKushSingh05 commented 2 months ago

GitHubTags:

A11yFunctional;#A11yTCS;#Desktopweb;#Win11;#Visual Studio Code Client;#VisualStudioCode-Web-Apr2021;#a11y-monacoeditor;#Keyboard;#SCIM:Bug28133995;#Functionality;

Environment Details:

URL: Monaco Editor (microsoft.github.io)

Monaco Editor Chromium edge Version: 126.0.2592.68 (Official build) (64-bit).

Repro Steps:

  1. Hit the URL: https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0-dev.20230707#XQAAAAJzAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzfibW_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKimARHSWlrTPOQHROITHxmAetfeRrm3VHdSe7_Etv6WpgzlH4vE8EOD3EPhJDl6tDpOO8RxKZbUytKns3T0NFFloo9Q21KsEBT298I6cyZc5-Glup9UHU6QTpv2Hjab6pZzB3ZO2RH-WGhzXse2-hNlgz6zCgsG8AjiqGg0ZzWzND7z09NmCQOQd6pfkNvO2zmMzFvHpTY8RFEy1urlQcQMb1HHLEESBi8m3Rr3UzFlKzY51hfYcz__QCePc and press enter
  2. Tab till Monaco editor.
  3. Verify whether after pressing alt+f1 accessibility option is opening or not.

Actual Behavior

When we are pressing alt+f1 key to expand accessibility option it's not opening.

Expected Behavior

When we are pressing alt+f1 key to expand accessibility option it should work, and access accessibility should open.

User Impact:

Keyboard only users will not be able to access the accessibility option.

Attachment:

Bug_4583_Keyboard

meganrogge commented 1 month ago

We do not have screen reader mode /the accessibility help dialog in the monaco-editor playground because it is a web page, which is already highly accessible, unlike our desktop VS code, which requires some fine tuning / information to accommodate screen reader users. Does something in the web page give an indication that alt+f1 should work?

rzhao271 commented 1 week ago

I still see the hint show up in the NVDA speech viewer on the latest dev version. Did the change get reverted?

meganrogge commented 1 week ago

@rzhao271 using the link the issue author provided and comparing that to the latest dev version, it is fixed for me.

https://github.com/user-attachments/assets/be8f0c8c-776c-4eb3-aacc-6eb09f1222c0

meganrogge commented 1 week ago

Ah, I see it if I click in this editor still.

Image

meganrogge commented 1 week ago

@hediet , could you pls work on this as it's an accessibility-sla issue and the due date is soon.