search

microsoft / ms-tpm-20-ref

Reference implementation of the TCG Trusted Platform Module 2.0 specification.
Other
343 stars 133 forks source link

TPMCmd: Remove _CRYPT_HASH_C_ #34

Closed josephlr closed 5 years ago

josephlr commented 5 years ago

The TpmTo*Hash files preform bespoke isolation to prevent name collisions, but this is not necessary to make the project build.

As the (now deleted) comment says, if there is a real collision, the linker will figure it out. Helps address #33

Signed-off-by: Joe Richey joerichey@google.com

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

amarochk commented 5 years ago

Hi Joseph,

Thank you for your PR. I've discussed this PR with other maintainers of the reference implementation, and the overall conclusion is that even though your patch will work for the sources in this github, many TPM vendors use different underlying crypto libraries, and this change may break their code. So we'd rather leave it as is.