search

microsoft / msagljs

A JavaScript graph layout engine: port of MSAGL
https://microsoft.github.io/msagljs/
MIT License
148 stars 15 forks source link

Split renderers #37

Closed levnach closed 1 year ago

levnach commented 1 year ago

I probably broke something.

pelikhan commented 1 year ago

We'll need to update the snippets in the docs too.

pelikhan commented 1 year ago

renderer-* is more like a tree. You rarely type this stuff, Intellisense finds it from type name

From: Lev Nachmanson @.> Sent: Saturday, January 28, 2023 12:46:39 PM To: microsoft/msagljs @.> Cc: Peli de Halleux @.>; Review requested @.> Subject: Re: [microsoft/msagljs] Split renderers (PR #37)

@levnach commented on this pull request.

In examples/webgl-renderer/src/app.tshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fmsagljs%2Fpull%2F37%23discussion_r1089810054&data=05%7C01%7Cjhalleux%40microsoft.com%7C46b2ca39607f4fbd54a308db0170c200%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638105356024219204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jawo3u5kOUTdVL1gQES91GY5winiyLiPo8Vbck0%2FYYM%3D&reserved=0:

@@ -1,7 +1,7 @@ import {dropZone} from './drag-n-drop' -import {Renderer, SearchControl, LayoutOptions} from @./renderer' +import {Renderer as WebGLRenderer, SearchControl, LayoutOptions} from @./webGLRenderer'

Renamed RendererSvg to SvgRenderer

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fmsagljs%2Fpull%2F37%23discussion_r1089810054&data=05%7C01%7Cjhalleux%40microsoft.com%7C46b2ca39607f4fbd54a308db0170c200%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638105356024219204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jawo3u5kOUTdVL1gQES91GY5winiyLiPo8Vbck0%2FYYM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKJW6BIT7NF4I6MM2HLWUWAS7ANCNFSM6AAAAAAUJNYUXM&data=05%7C01%7Cjhalleux%40microsoft.com%7C46b2ca39607f4fbd54a308db0170c200%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638105356024219204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=onsuPXM3q05Y4pmF9Qm69NRNFDCfIpg43bVQoKpTSEA%3D&reserved=0. You are receiving this because your review was requested.Message ID: @.***>