search

microsoft / msccl

Microsoft Collective Communication Library
Other
304 stars 29 forks source link

Compilation failure #55

Open JihaoXin opened 1 year ago

JihaoXin commented 1 year ago

I failed the build, with uint64_t undefined. After #include <cstdint> in src/include/collectives.h it works. Maybe there should be a better way.

../../include/collectives.h(18): error: identifier "uint64_t" is undefined
    uint64_t scalarArg;
    ^
1 error detected in the compilation of "custom_collective.cu".
make[2]: *** [/home/ubuntu/jihao/msccl/build/obj/collectives/device/Makefile.rules:2274: /home/ubuntu/jihao/msccl/build/obj/collectives/device/custom_collective_max_i64.o] Error 2
saeedmaleki commented 1 year ago

it really depends on the compiler you are using. But in general, I like your idea of including having the explicit include to avoid these kinds of issues. I will fix this in near future. Thanks for pointing it out!

saeedmaleki commented 1 year ago

can you please raise a PR for this fix, @JihaoXin ?

JihaoXin commented 1 year ago

Thank you Saeed, I've created the PR.