search

microsoft / msix-packaging

MSIX SDK
MIT License
967 stars 163 forks source link

[Feature Request] File Explorer should display MSIX/ APPX/ MSIXBUNDLE/ APPXBUNDLE packages' Icons instead of App Installer Icon. #387

Open 77376 opened 3 years ago

77376 commented 3 years ago

I was not sure where to post this small feature request, so I ended up posting here.

Untitled During offline Sideloading scenarios in windows 10, Just like any regular .EXE file today can display their icon in file explorer, MSIX/ APPX packages should also display their corresponding Icons too in file explorer. It eases to distinguish among multiple MSIX/APPX packages easily without double clicking it. It also makes MSIX packages feel like native in windows 10 ecosystem for general consumers. Thanks.

77376 commented 3 years ago

Didn't post on Feedback Hub because lots of similar feature requests are already there rotting for several years and no team have never ever bothered to respond, so posted it here with a hope that MSIX packaging team will at least take a look.

jvintzel commented 3 years ago

Thanks for the feedback. Right now we are modeling after the msi model where it is a standard icon. I've tagged this as a feature in our backlog to look at in the future.

77376 commented 3 years ago

@jvintzel It will be great if packages could display their own separate icons instead of an generic icon . anyway, thanks for taking this into consideration.

soumyamahunt commented 3 years ago

@77376 showing only app icon for .exe files is really confusing for end users. If the end user has chosen to hide known file extensions(which is default for windows) then they have no idea what kind of file it is, which is how many malwares trick users to open them. @jvintzel I think combined approach could be taken in which the app icon would be displayed as an overlay over the current icon(which user has choice to turn on/off as they can already do so for video thumbnails).

RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/msix-packaging/issues/387#issue-710703099

@77376, I affirm that @soumyamahunt's comment is actually utterly necessary for security. It's well known how difficult ensuring that a file extension is displayed can be, considering the amount of potentially disruptive UTF-8 control codes permitted in NTFS filenames, and the absurd fact that file extensions still aren't even displayed by default. Consequently, we shouldn't sacrifice the ability to quickly understand that something is executable for merely aesthetic reasons.

Irrespective, some potentially feasible compromises exist:

  1. We could display the application icons as overlays, when the application provides an icon of the correct size (in most cases, 16 px).
  2. We could display the overlays as thumbnails, like https://invent.kde.org/system/dolphin/-/tree/7ef6169026c6a79570675dfa9b7625138e8d9309#dolphin does, rendering the installation icon above it. This would appear to contradict all that I've aforestated, but considering that everyone recognises a shortcut easily, it might work.

However, I expect that the current overlay limitations prevent this.