search

microsoft / msix-packaging

MSIX SDK
MIT License
963 stars 163 forks source link

Add logic to allow pseudo locales in AppxBundleManifest.xml file of .msixbundle packages #562

Closed vishmicrosoft closed 1 year ago

vishmicrosoft commented 1 year ago

ISSUE : https://github.com/microsoft/msix-packaging/issues/516

ROOT CAUSE : In "AppxBundleManifest.xml" of "WindowsTerminal.msixbundle", there are pseudo locales present in "Resource" tag.

image

Parsing of AppxBundleManifest.xml file is failing during unpack because of above mentioned pseudo locales as the max length limit for "Region" in "Language" is set to 4 and length of "Region" in pseudo locales "QPS-PLOCA" and "QPS-PLOCM" is 5.

FIX : Allow pseudo locales in constructor of class "Bcp47Tag" by using a flag "allowPseudoLocale". So, when "AppxBundleManifest.xml" is parsed in "AppxBundleManifest.cpp", "allowPseudoLocale" is passed as "true" in constructor of class "Bcp47Tag".

msftrubengu commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.