microsoft / msix-packaging

MSIX SDK
MIT License
963 stars 163 forks source link

User/masudars/update openssl 1 1 1t #579

Closed Madhusudhan-MSFT closed 1 year ago

Madhusudhan-MSFT commented 1 year ago

CG Fix for OpenSSL. The fix includes

  1. Removing old openssl 1_1_1j subtree directory from the repo folder
  2. Re-add openssl 1_1_1t subtree that contains security fix

''git subtree add --prefix lib/openssl https://github.com/openssl/openssl.git OpenSSL_1_1_1t --squash''

[How Validated:]

  1. makewin.cmd x64 a. .vs\msixtest\msixtest.exe All tests passed (11292 assertions in 72 test cases)
  2. makewin.cmd x64 -px a. .vs\msixtest\msixtest.exe All tests passed (11292 assertions in 72 test cases)

But windows platform doesn't use openssl and I am relaying build results from mac/ios build pipeline as linux build pipeline is broken.

msftrubengu commented 1 year ago

makewin.cmd x64 doesn't use OpenSSL but the windows crypo APIs. Try makewin.cmd x64 --crypto-openssl or set up WSL for use makelinux.

Also, since we don't have CI for Windows using OpenSSL I suggest you do that in master first to confirm it builds, then try it with the new subtree.

Madhusudhan-MSFT commented 1 year ago

Looks like there are some breaking changes probably new file additions and function reference from there what is causing validation pipeline failure. I will some time to analyze what is causing compilation failure and update the fix.

I wil also try ( if that makes it any easier for the fix the failures)

makewin.cmd x64 --crypto-openssl or set up WSL for use makelinux.

Madhusudhan-MSFT commented 1 year ago

msix-packaging Linux CI - failure seems to be due to infra issue as it fails with below error.

##[warning]An image label with the label ubuntu-18.04 does not exist.
,##[error]The remote provider was unable to process the request.
msftrubengu commented 1 year ago

Can you open an issue to update the linux image?

Also since you are updating the subtree, don't squash this PR

Madhusudhan-MSFT commented 1 year ago

opened #580 to track linux image update.