search

microsoft / msix-packaging

MSIX SDK
MIT License
963 stars 163 forks source link

[MSIX app attach] Enable logging of output to a file for the IT Pro. #600

Open Smohamed-MSFT opened 9 months ago

Smohamed-MSFT commented 9 months ago

Why is this change being made? Support IT Pro by allowing the output of logging errors to file.

What changed? Added a -output flag that allow to specify a file location to output logs to after crash.

How was the change tested? Validated by reverting to previous commit as the current wasn't building. Successfully output the errors to a log file when specified using the -output flag.

Smohamed-MSFT commented 8 months ago

Why is this change being made? Support IT Pro by allowing the output of logging errors to file.

What changed? Added a -output flag that allow to specify a file location to output logs to after crash.

How was the change tested? Validated by reverting to previous commit as the current wasn't building. Successfully output the errors to a log file when specified using the -output flag.

sreading-MSFT commented 8 months ago 
    std::wcout << std::endl;

At a very high level I'm trying to figure out if the feature this code review is trying to implement would work better by just changing all the std::wcout uses in this particular function to std::wcerr and then just let the caller pipe the error output to a file rather than having a separate command line arg.

Refers to: MsixCore/msixmgr/msixmgr.cpp:135 in 2ce316d. [](commit_id = 2ce316dc7a499052bb6bac3ea6ef314a40d1e304, deletion_comment = False)

sreading-MSFT commented 7 months ago

Looks like my username isn’t marked as valid for approving on this project for checkin - but thank you for all the updates. I approve.