microsoft / msix-packaging

MSIX SDK
MIT License
963 stars 163 forks source link

[BUG] cmake_minimum_required should be set to a more reasonable value #629

Open nephatrine opened 1 month ago

nephatrine commented 1 month ago

Project MSIX SDK

Describe the bug Commit d375318f01023aa2c2f8d685e804e6c979e10d89 changed cmake_minimum_required to 3.29.0, but I do not see any technical reason for this specific value to have been chosen and it breaks building on systems like Debian stable which is still at 3.25.1, for example.

I can manually change the cmake_minimum_required to 3.25 and build using makeLinux.sh and get working binaries without any issues. The cmake_minimum_required should be the actual minimum required version, not necessarily the version your CI pipeline happens to be using, at least if you intend for others to be able to clone the repo and build it on their systems too.

Yes, it's trivial to just change the value across all the CMakeLists.txt files myself and alternatively there actually is a CMake 3.29 package in Debian stable-backports if it ever really become necessary, but it seems strange to break people's builds that were previously working when it isn't actually necessary.