search

microsoft / msquic

Cross-platform, C implementation of the IETF QUIC protocol, exposed to C, C++, C# and Rust.
MIT License
4.03k stars 530 forks source link

Retry flaky test #4332

Closed ami-GS closed 3 months ago

ami-GS commented 4 months ago

Description

Several tests sometimes fail due to randomness and slower test environment on Github Action. This change executes retry once if first trial fails. Then failure twice in a row is considered as actual failure. (e.g. take over 10sec to start processing received packets which causes IDLE.TIMEOUT then shutdown its connection.)

Testing

See automation....

Documentation

N/A

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.41%. Comparing base (2f98992) to head (3ba2137). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4332 +/- ## ========================================== - Coverage 85.68% 84.41% -1.27% ========================================== Files 56 56 Lines 15384 15384 ========================================== - Hits 13182 12987 -195 - Misses 2202 2397 +195 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ami-GS commented 4 months ago

Error annotation is shown, but not treated as failure by retry

image image