search

microsoft / msquic

Cross-platform, C implementation of the IETF QUIC protocol, exposed to C, C++, C# and Rust.
MIT License
3.92k stars 525 forks source link

Fix test log path sanitation #4352

Closed anrossi closed 2 weeks ago

anrossi commented 2 weeks ago

Description

An issue encountered when adding a new test resulted in the powershell process crashing. The problem was the auto-generated test name contained characters that were invalid in a directory path, which wasn't sanitized by the existing log path creation code. This resulted in powershell crashing when trying to create the log directory.

This change updates the log path creation code to sanitize the test name for all invalid path characters.

Testing

Locally run works fine and CI to validate other platforms.

Documentation

N/A

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.19%. Comparing base (b7b2021) to head (7666814).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4352 +/- ## ========================================== + Coverage 84.27% 85.19% +0.92% ========================================== Files 56 56 Lines 15426 15426 ========================================== + Hits 13000 13142 +142 + Misses 2426 2284 -142 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.