search

microsoft / msquic

Cross-platform, C implementation of the IETF QUIC protocol, exposed to C, C++, C# and Rust.
MIT License
4.03k stars 530 forks source link

Stream Multi Receive implementation #4383

Closed ami-GS closed 3 months ago

ami-GS commented 3 months ago

Description

Stream Multi Receive internal feature. Dispatched from https://github.com/microsoft/msquic/pull/4182

Testing

RecvBufferTest.cpp

Documentation

N/A

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 12.82051% with 68 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (394f1d1) to head (b729236).

Files Patch % Lines
src/core/recv_buffer.c 12.82% 68 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4383 +/- ## ========================================== + Coverage 84.40% 85.12% +0.71% ========================================== Files 56 56 Lines 15426 15457 +31 ========================================== + Hits 13021 13157 +136 + Misses 2405 2300 -105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nibanks commented 3 months ago

Just include the recv buffer and test changes? Not everything else

ami-GS commented 3 months ago

settings.c and stream.c etc. are for public api?

ami-GS commented 3 months ago

@nibanks This PR is ready to go. there is stall issue, but it is with API implementation