search

microsoft / mssql-jdbc

The Microsoft JDBC Driver for SQL Server is a Type 4 JDBC driver that provides database connectivity with SQL Server through the standard JDBC application program interfaces (APIs).
MIT License
1.06k stars 427 forks source link

Added a missing unlock in `getDestinationMetadata()` #2484

Closed Jeffery-Wasty closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.80%. Comparing base (0e97689) to head (1c0ff80). Report is 2 commits behind head on main.

Files Patch % Lines
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2484 +/- ## ============================================ + Coverage 50.78% 50.80% +0.01% - Complexity 3888 3890 +2 ============================================ Files 145 145 Lines 33481 33482 +1 Branches 5690 5691 +1 ============================================ + Hits 17004 17010 +6 + Misses 14030 14028 -2 + Partials 2447 2444 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

David-Engel commented 3 months ago

Also, you should add a test to cover the scenario that the reporting issue manifests.