search

microsoft / msstore-cli

Microsoft Store CLI
MIT License
80 stars 8 forks source link

`Poll` command doesn't Poll #24

Open MatthewSteeples opened 10 months ago

MatthewSteeples commented 10 months ago

Please see below for command and output

msstore submission poll 9NXXXXXXXXXX

Found Pending Submission.
Submission Status - Certification

✅ Retrieving Pending Submission
✅ Submission retrieved
Submission commit success! Here is some data:
Packages:
File_2.0.39235.0_x86_bundle.msixupload
File_2.0.44817.0_x86.msixbundle
File_2.0.45109.0_x86.msixbundle

The three files listed are part of the submission that is pending, and the submission is at the certification stage, so those bits are correct. The command doesn't retry though, it just exits

azchohfi commented 10 months ago

The poll command waits until the submission status is not "CommitStarted". We could poll until we hit a *Failed state, a Published state, or a Release state (and the submission has a manual publish mode), but Certification can take days to finish. Are you running the tool locally or on a CI/CD env? We assumed users wouldn't want to lock a pipeline/release until it is 100% done, since it can take that long. We could timeout after an hour, or have it as a parameter.

What is your specific scenario?

MatthewSteeples commented 10 months ago

I was just experimenting so don't (yet) have a scenario for it. The docs may need updating though:

https://learn.microsoft.com/en-gb/windows/apps/publish/msstore-dev-cli/submission-poll-command - Polls until the existing submission is PUBLISHED or FAILED

jakubmeysner commented 4 months ago

The current behavior makes the most sense compared to what's described in the docs, but for some use cases a flag allowing you to poll until the submission is published or fails could be useful.