search

microsoft / mstic

Microsoft Threat Intelligence
https://www.microsoft.com/en-us/security/blog/microsoft-security-intelligence/
Creative Commons Attribution 4.0 International
142 stars 28 forks source link

Fix broken github action for updating public IP ranges #31

Closed chase9 closed 1 month ago

chase9 commented 1 month ago

The Github action to update Microsoft's public IP ranges has been broken since lxml moved a core dependency out to its own package. This PR adds that new package as a dependency for the action. I'm also comitting the updated IP range file which was generated.

chase9 commented 1 month ago

@microsoft-github-policy-service agree

chase9 commented 1 month ago

I also added the missing dep to the Mitre action, which allows the action to run, but there is another issue with the action which causes it to fail. I believe that is beyond the scope of the PR.

ashwin-patil commented 1 month ago

Thank you @chase9.

chase9 commented 1 month ago

Hi @ashwin-patil, you caught me just as I was working on fixing the node depreciation warnings and the failures when there have been no new weekly updates to the IP ranges. I think you have a version in master that is half fixed. My branch now has these fixes. Do you want me to open a new PR?

ashwin-patil commented 1 month ago

Hi @ashwin-patil, you caught me just as I was working on fixing the node depreciation warnings and the failures when there have been no new weekly updates to the IP ranges. I think you have a version in master that is half fixed. My branch now has these fixes. Do you want me to open a new PR?

Got it. Yes, Please open a PR . I will keep an eye on the updated actions run. There have been changes on github action bot account as well which may need additional fix.

chase9 commented 1 month ago

Sounds good, PR opened at #32. Thanks!