Closed Tatsuya-hasegawa closed 5 months ago
Oops, I noticed pulled my folk repository's main instead of microsoft:main before this commit. So This PR's Files Changes diff includes the previous PR #731 . The correct diff to microsoft:main is only the area of "This branch has conflicts that must be resolved" below.
I'm sorry. Kind regards,
Got it, I have completely fixed. This PR's Files Changes diff is correct now. Best regards,
Thank you in advance for your eye, @ianhelle
@ianhelle
Thanks for your check and the advices. I fixed them by this commit.
% git commit -m "small changes for exceptional messages"
Check Yaml...........................................(no files to check)Skipped
Check JSON...........................................(no files to check)Skipped
Trim Trailing Whitespace.................................................Passed
black....................................................................Passed
pylint...................................................................Passed
flake8...................................................................Passed
isort (python)...........................................................Passed
pydocstyle...............................................................Passed
check_reqs_all...........................................................Passed
[add_token_expire_check_to_splunk_driver eeb9df46] small changes for exceptional messages
2 files changed, 8 insertions(+), 7 deletions(-)
Would you kindly check them again? Best regards,
Thanks for your approval and merge.
@Tatsuya-hasegawa - thank you, once again for the contribution. It's awesome to have someone actively working on the Splunk support!
Hello,
I have some additional things to SplunkDriver.
The biggest one is that JWT bear_token's expiration check was implemented by using pyjwt which is already in requirement.txt. In addition, I put some distinguish messages for each auth method when connecting Splunk. And then modify an error in Splunk QueryProvider doc.
Local code check has been succeeded as following.
The JWT expiration time is shown by this commit.
This is an expire message, in this case, I modified the current time to over the expiration date forcely in order to appear this message.
Thank you. Best regards,