search

microsoft / msticpy

Microsoft Threat Intelligence Security Tools
Other
1.77k stars 319 forks source link

UrlSummary .. not working as expected #792

Closed SunChero closed 3 months ago

SunChero commented 3 months ago

Hi Guys, im playing with msticpy for the first time trying to run some sample/examples notebook from the Azure-Sentinel-Notebooks samles but everytime .. it seems to get stuck in call to URLSummary function

not sure if anybody else get the same issue or error

Thank you 


File /opt/conda/lib/python3.11/site-packages/msticnb/nb/azsent/url/url_summary.py:168, in URLSummary.run(self, value, data, timespan, options, **kwargs)
    163 result = URLSummaryResult(
    164     notebooklet=self, description=self.metadata.description, timespan=timespan
    165 )
    167 url = value.strip().lower()
--> 168 _, domain, tld = tldextract.extract(url)
    169 domain = f"{domain.lower()}.{tld.lower()}"
    170 domain_validator = DomainValidator()

TypeError: cannot unpack non-iterable ExtractResult object
ianhelle commented 3 months ago

Hi @SunChero This seems more likely an issue in our mstic notebooklets package. I'll investigate.

ianhelle commented 3 months ago

This should be fixed in the latest release of msticnb - mstic notebooklets. To update from notebook

%pip install --upgrade msticnb

If updating from a terminal, make sure you have activated the azureml Python 3.10 conda environment before running the pip update.

SunChero commented 3 months ago

much appreciated .. thank you