microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

MdeModulePkg: Only build SmmLockBoxPeiLib for IA32 and X64 #1008

Closed kenlautner closed 3 months ago

kenlautner commented 3 months ago

Description

Move LockBoxLibPei and add Null lib to satisfy modules that aren't IA32 or X64 compatible.

How This Was Tested

Passes CI.

Integration Instructions

N/A

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@1795de8). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1008 +/- ## ================================================= Coverage ? 18.74% ================================================= Files ? 105 Lines ? 9052 Branches ? 0 ================================================= Hits ? 1697 Misses ? 7355 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1008/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `18.74% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

makubacki commented 3 months ago

Please update the PR title to be a bit more specific to the actual change.

makubacki commented 3 months ago

Please update the PR title to be a bit more specific to the actual change.

Like "MdeModulePkg: Only build SmmLockBoxPeiLib for IA32 and X64"