microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
239 stars 122 forks source link

MdeModulePkg: Localize the mInternalRT global var in RuntimeResetSystemLib #1027

Closed os-d closed 2 months ago

os-d commented 2 months ago

Description

This avoids a name collision with UefiRuntimeLib which causes a linker error if a platform includes both libraries.

How This Was Tested

2311 commit.

Integration Instructions

N/A.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@1c424c1). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1027 +/- ## ================================================= Coverage ? 17.80% ================================================= Files ? 107 Lines ? 10236 Branches ? 2105 ================================================= Hits ? 1823 Misses ? 8399 Partials ? 14 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1027/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `17.80% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.