microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[REBASE && FF][202405][SPLIT]NetworkPkg/UefiPxeBcDxe: Mark the device as removed when it is unplugged #1036

Closed Flickdm closed 3 months ago

Flickdm commented 3 months ago

Description

Network stack fails when USB nic is removed after initialization. This change marks it removed but doesn't clean up memory allocations so that other code holding onto and using that memory doesn't cause an exception.

This change was split off the commit: https://github.com/microsoft/mu_basecore/commit/7a38833

How This Was Tested

Release/202405

Integration Instructions

N/A

Upstream

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@de0afe3). Learn more about missing BASE report.

Files Patch % Lines
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c 0.00% 56 Missing :warning:
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c 0.00% 38 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1036 +/- ## ================================================ Coverage ? 0.55% ================================================ Files ? 165 Lines ? 71222 Branches ? 1754 ================================================ Hits ? 394 Misses ? 70821 Partials ? 7 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1036/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.