microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
239 stars 122 forks source link

BaseTools/Plugin/RustEnvironmentCheck: Use pytools Rust helpers #1037

Closed makubacki closed 1 month ago

makubacki commented 1 month ago

Description

The plugin implementation has moved to edk2-pytool-extensions so it can be reused for plugins targeting different scenarios such as public/generic (this plugin) or custom internal environments that may need to add on additional functionality.

This simplifies this plugin's implementation significantly.

How This Was Tested

Integration Instructions

An id has been added to the plugin YAML file (rust-env-check). This retains the same scope as before (rust-ci) but allows a custom version of the plugin to override this version by specifying:

In its YAML file. Otherwise, no integration work is needed.

There is an example of code that sets id_override (via generated YAML) here for reference.

edk2-pytool-extenions 0.27.10 is required this change to work due to the new functionality used in that release.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.35%. Comparing base (7cf3382) to head (7b811c1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202311 #1037 +/- ## =============================================== Coverage 1.35% 1.35% =============================================== Files 1304 1304 Lines 333790 333790 Branches 5103 5103 =============================================== Hits 4512 4512 Misses 329195 329195 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1037/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (ø)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.40% <ø> (ø)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (ø)` | | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.