microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
239 stars 122 forks source link

[CHERRY-PICK] [Rebase & FF] 202405: MdePkg/UefiDebugLibDebugPortProtocol: make ExitBootServicesCallback() static #1043

Closed VivianNK closed 1 month ago

VivianNK commented 1 month ago

Description

Since this is a library, make the function ExitBootServicesCallback() STATIC to prevent the likelihood that it collides with other symbols.


REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3083

Cherry-picked from edk2: 55b0437

Abandoned PR 1003 in favor of this upstream change


How This Was Tested

CI

Integration Instructions

N/A

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@86e6be1). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1043 +/- ## ================================================ Coverage ? 3.30% ================================================ Files ? 495 Lines ? 41428 Branches ? 1725 ================================================ Hits ? 1368 Misses ? 39646 Partials ? 414 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1043/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1043/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `3.30% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

makubacki commented 1 month ago

Is the breaking change tag intentional? If so, that should be explained in integration instructions.

VivianNK commented 1 month ago

Is the breaking change tag intentional? If so, that should be explained in integration instructions.

accidental. Removed