microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

2405: [CHERRY-PICK] BaseTools/CodeQL: Removed unused static function query #1044

Closed makubacki closed 3 months ago

makubacki commented 3 months ago

Description

This query seems to produce a rate of false positives with some common patterns in edk2 like passing function pointers for callback.

Due to the usage of STATIC instead of static particularly for functions, this query was rarely used in the past. It is removed here to prevent future false positives.

How This Was Tested

Integration Instructions

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@ec43e8d). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1044 +/- ## ================================================= Coverage ? 1.46% ================================================= Files ? 1434 Lines ? 359091 Branches ? 3596 ================================================= Hits ? 5247 Misses ? 353756 Partials ? 88 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1044/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1044/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.60% <ø> (?)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1044/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.41% <ø> (?)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1044/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.50% <ø> (?)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1044/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.75% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

VivianNK commented 3 months ago

FYI @makubacki looks like the branch is requiring an update and is blocked from auto-merging.

makubacki commented 3 months ago

FYI @makubacki looks like the branch is requiring an update and is blocked from auto-merging.

Rebased and pushed