microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
239 stars 122 forks source link

UnitTestFrameworkPkg\UnitTestFrameworkPkg.dec: Reenable access to PrivateInclude. #1060

Closed apop5 closed 1 month ago

apop5 commented 1 month ago

Description

mu_plus DxeMemoryProtectionApp and XmlSupportPkg's UnitTestResultReportJUnitFormatLib\UnitTestResultReportLib.inf both make use of internals of the UnitTestFrameworkPkg's PrivateIncludes folder.

Temporarily adding back the PrivateIncludes folder while those others are examined to try to remove the dependecy.

How This Was Tested

Local CI on mu_plus repo using 202405 branches.

Integration Instructions

N/A

apop5 commented 1 month ago

Tracking removal https://github.com/microsoft/mu_plus/issues/529

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@7f6831e). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1060 +/- ## ================================================= Coverage ? 1.51% ================================================= Files ? 1436 Lines ? 359840 Branches ? 5355 ================================================= Hits ? 5458 Misses ? 354285 Partials ? 97 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1060/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1060/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (?)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1060/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.41% <ø> (?)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1060/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (?)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1060/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.75% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.