microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
239 stars 122 forks source link

BaseTools: GenC: Fixing an edge case where BUILDMODULE might fail #1063

Closed kuqin12 closed 1 month ago

kuqin12 commented 1 month ago

Description

This change fixed an edge case when invoking the build process with "BUILDMODULE" and no stack cookie is involved (i.e. pure assembly code), the build might fail.

The existing code path is written to handle such case, but the error method is actually breaking the build. This change demotes the message to warning.

Signed-off-by: Kun Qin kun.qin@microsoft.com

(cherry picked from commit ca0ae3c4a56c1eb0cd2c0c84c34bd5a09f58c3c3)

How This Was Tested

This was tested on QEMU Q35 build process.

Integration Instructions

N/A

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@4473478). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1063 +/- ## ================================================= Coverage ? 1.51% ================================================= Files ? 1436 Lines ? 359840 Branches ? 5355 ================================================= Hits ? 5458 Misses ? 354285 Partials ? 97 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1063/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (?)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.41% <ø> (?)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (?)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.75% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.