microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
239 stars 122 forks source link

Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c #1065

Closed kenlautner closed 1 month ago

kenlautner commented 1 month ago

Description

Changes the newly added CpuDeadLoops in PiSmmCpuDxeSmm.c into PANIC calls to give more information on issues that are hit instead of hanging the system.

How This Was Tested

N/A

Integration Instructions

N/A

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@d753ffc). Learn more about missing BASE report.

Files Patch % Lines
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1065 +/- ## ================================================ Coverage ? 4.75% ================================================ Files ? 133 Lines ? 26092 Branches ? 534 ================================================ Hits ? 1240 Misses ? 24828 Partials ? 24 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1065/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1065/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.75% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.