search

microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[202405] Add Cumulative CodeQL changes. #1074

Closed apop5 closed 1 month ago

apop5 commented 2 months ago

Description

Cumulative CodeQL fixes for the release 202405 Branch.

13dff4ff03 f26f86dd85 e97c27388d 564f262817 769b019d1d 4828ebb596 4c372a273c 5f165d29f0 006dc1f1cd c99d59f91f f648481185 c70d96e19e 7c60e3309d 2deccbe69e 2c4db3932a ec7a96c424 45219b51fa b47eb1fb37 1cd17c14ed fec2cd9e81 326dde3a9f a420f6627f 4f4cc7d81a d2e5518865 9496601f8f 83ec756f7c 192d343194 55ad1f28bd e71970bff9 be03b5b183 b9d04a0817 f495191509 6acf82c3f5 2c6ee990f4 8398844583 f90d7a8ca3 5464d1661f 4c082e3c26 f8616ec497 070d25db52 442aab874c fe7078e3e0 e0b29646ba 798cfa3b92 92dc249f0c 0c3eaacafc

How This Was Tested

Ran Local CI.

Integration Instructions

N/A

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 1.68176% with 2280 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@2fbaccc). Learn more about missing BASE report.

Files Patch % Lines
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c 0.00% 235 Missing :warning:
...Pkg/Library/UefiDevicePathLib/DevicePathFromText.c 14.08% 183 Missing :warning:
...ary/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c 0.00% 144 Missing :warning:
MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c 0.00% 120 Missing :warning:
...deModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c 0.00% 112 Missing :warning:
...ModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c 0.00% 98 Missing :warning:
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c 0.00% 74 Missing :warning:
MdeModulePkg/Universal/PCD/Pei/Pcd.c 0.00% 66 Missing :warning:
NetworkPkg/Ip6Dxe/Ip6Nd.c 0.00% 63 Missing :warning:
MdeModulePkg/Universal/HiiDatabaseDxe/Database.c 0.00% 61 Missing :warning:
... and 111 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1074 +/- ## ================================================= Coverage ? 1.59% ================================================= Files ? 1448 Lines ? 362482 Branches ? 5632 ================================================= Hits ? 5776 Misses ? 356599 Partials ? 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1074/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1074/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <0.06%> (?)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1074/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.42% <11.89%> (?)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1074/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <0.00%> (?)` | | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1074/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (?)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1074/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.73% <2.55%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

apop5 commented 1 month ago

Additional Files changed on top of 202311 ShellPkg\Library\UefiShellDebug1CommandsLib\EditMenuBar.c (missing freepool in MenuBarRefresh) ShellPkg\Library\UefiShellDebug1CommandsLib\EfiDecompress.c (safeintlib in ShellCommandRunEfiDecompress) ShellPkg\Library\UefiShellBcfgCommandLib\UefiShellBcfgCommandLib.c (handle out of resources case to exit)