[SQUASH ON REBASE] MdeModulePkg: UefiBootManagerLib: Move SetVariableCall

[os-d]

Description

BmLoadOption.c: Move Locking OptionName variable after calling SetVariable.

This commit was cherry-picked from 7c17fd9b3457a546dbcb7746a4f9aeebd4f85d1f. It was partially taken in https://github.com/microsoft/mu_basecore/commit/3483ae8dfa4165467f74648a40d74b8d9d63a545, but that commit merely added the SetVariable call in the new place, did not comment out the old location. As a result, we were attempting to call SetVariable after we had done a FreePool on Variable, which resulted in an exception.

For future integrations, this should be squashed with the above commit.

• [x] Impacts functionality?
  • Functionality - Does the change ultimately impact how firmware functions?
  • Examples: Add a new library, publish a new PPI, update an algorithm, ...
• [ ] Impacts security?
  • Security - Does the change have a direct security impact on an application, flow, or firmware?
  • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
• [ ] Breaking change?
  • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
  • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
• [ ] Includes tests?
  • Tests - Does the change include any explicit test code?
  • Examples: Unit tests, integration tests, robot tests, ...
• [ ] Includes documentation?
  • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
  • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

Booted SBSA to an OS.

Integration Instructions

N/A.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@309cd8e). Learn more about missing BASE report.

Files	Patch %	Lines
...odulePkg/Library/UefiBootManagerLib/BmLoadOption.c	0.00%	11 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/202405 #1080 +/- ## ================================================= Coverage ? 0.68% ================================================= Files ? 642 Lines ? 219453 Branches ? 1356 ================================================= Hits ? 1502 Misses ? 217904 Partials ? 47 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1080/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1080/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.