search

microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[202405][REBASE&FF] Variable Argument List macros reversions #1089

Closed Javagedes closed 2 months ago

Javagedes commented 2 months ago

Description

This reverts the following commits:

How This Was Tested

Confirmed this does not affect multiple platform builds using VS compiler

Integration Instructions

N/A

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@63fc132). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1089 +/- ## ================================================= Coverage ? 1.59% ================================================= Files ? 1448 Lines ? 361057 Branches ? 5553 ================================================= Hits ? 5766 Misses ? 355184 Partials ? 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1089/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (?)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.41% <ø> (?)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (?)` | | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (?)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.77% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

os-d commented 2 months ago

We can revert this in the same PR: https://github.com/microsoft/mu_basecore/commit/7281ec2297. Also, I don't think this needs to be a breaking change. We do not believe any platform will break because of this, nor are there integration steps to fix it, so this would go in general category of shouldn't break but if it does, let us know.

makubacki commented 2 months ago

I will approve. Waiting for @Javagedes to get back on an additional platform build that I recommended to test.

Javagedes commented 2 months ago

We can revert this in the same PR: 7281ec2297. Also, I don't think this needs to be a breaking change. We do not believe any platform will break because of this, nor are there integration steps to fix it, so this would go in general category of shouldn't break but if it does, let us know.

Sounds good. I was being overly pessamistic with marking it as a breaking change. I'll undo that portion and also revert the PR you mentioned, as a REBASE&FF

Javagedes commented 2 months ago

@makubacki The additional platform was confirmed to successfully build on windows for DEBUG and RELEASE targets.