search

microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol #1106

Closed TsunFeng closed 3 weeks ago

TsunFeng commented 2 months ago

Description

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol

For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

TsunFeng commented 2 months ago

Hi @VivianNK, @apop5 and @os-d Could you help review this change? Thanks, TF

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 1.59%. Comparing base (a952e84) to head (052b49c).

Files with missing lines Patch % Lines
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/202405 #1106 +/- ## ============================================== - Coverage 1.59% 1.59% -0.01% ============================================== Files 1448 1448 Lines 362491 362501 +10 Branches 5632 5632 ============================================== Hits 5776 5776 - Misses 356608 356618 +10 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1106/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (ø)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.42% <ø> (ø)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <0.00%> (-0.01%)` | :arrow_down: | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (ø)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TsunFeng commented 1 month ago

Hi @makubacki, @apop5 and @os-d, I would really appreciate it if you could review this change for me.

Thanks, TF

TsunFeng commented 1 month ago

Hi @makubacki, I've replied to your question in the comment. Could you please take a look when you have a moment? Thank you.

TF

TsunFeng commented 1 month ago

Hi @makubacki, I would appreciate it if you could review this PR at your earliest convenience. Your feedback is crucial for moving next unit test. Thank you.

TF

VivianNK commented 1 month ago

@TsunFeng Please change the PR to target branch dev/202405. Moving forward we will be using dev branches to make changes to the latest release branch. @apop5

TsunFeng commented 1 month ago

Hi @VivianNK & @apop5 The PR has been updated to target dev/202405. Please help merge to the main branch, Thank You! TF

VivianNK commented 1 month ago

Hi @VivianNK & @apop5 The PR has been updated to target dev/202405. Please help merge to the main branch, Thank You! TF

image The target branch still shows as release/202405 but should be dev/202405

TsunFeng commented 4 weeks ago

Hi @VivianNK & @apop5 The PR has been updated to target dev/202405. Please help merge to the main branch, Thank You! TF

image The target branch still shows as release/202405 but should be dev/202405

Sorry, it's my mistake. I have changed to correct target branch.