codecov-commenter
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 1.59%. Comparing base (
2acf969) to head (726ee0d).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## release/202405 #1131 +/- ## ================================================== - Coverage 1.59% 1.59% -0.01% ================================================== Files 1448 1448 Lines 362487 362490 +3 Branches 5632 5632 ================================================== Hits 5776 5776 - Misses 356604 356607 +3 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1131/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR aims to prevent a buffer overrun issue found in FtwGetLastWriteHeader function.As per the current code, when there is a malformed blocks (with all bytes as 0s) then
Offset += FTW_WRITE_TOTAL_SIZE (FtwHeader->NumberOfWrites, FtwHeader->PrivateDataSize)would access beyond FtwWorkSpaceSize.Also added the signature check to validate work space
[x] Impacts functionality?
[ ] Impacts security?
[ ] Breaking change?
[ ] Includes tests?
[ ] Includes documentation?
How This Was Tested
Cherry-picked from edk2.
Integration Instructions
N/A.