microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

Add Line Ending plugin #1150

Open kenlautner opened 4 weeks ago

kenlautner commented 4 weeks ago

Description

Cherry-pick the LineEndingCheck plugin in its entirety as well as update all line endings to be CRLF to pass the new pipeline check.

The commits included from 202311: 8080124b16 6ddc3a56ea 59f33826b1 24a4f428e8 418f07b5b8

These commits do the following:

Revert the temporary commit disabling the ARM and ARM64 pipeline builds for CI and Basetools. This ensures that all normal Mu CI is run after this point.

Fixed a bug where the plugin would fail if not run from the projects root directory.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

N/A

Integration Instructions

N/A

github-actions[bot] commented 4 weeks ago

⚠️ Please add a meaningful PR title (remove the 'Personal/' prefix from the title).

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.44%. Comparing base (f82e02d) to head (c797865).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/202405 #1150 +/- ## ============================================== - Coverage 1.59% 1.44% -0.15% ============================================== Files 1448 1447 -1 Lines 362501 360385 -2116 Branches 5632 0 -5632 ============================================== - Hits 5776 5204 -572 + Misses 356618 355181 -1437 + Partials 107 0 -107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1150/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.61% <ø> (-0.07%)` | :arrow_down: | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.92% <ø> (-0.50%)` | :arrow_down: | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.50% <ø> (-0.05%)` | :arrow_down: | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `28.75% <ø> (-1.66%)` | :arrow_down: | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.36% <ø> (-0.37%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

makubacki commented 3 weeks ago

Please update the PR title and description to be more descriptive and accurate to the changes.