search

microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[REBASE&FF] MdeModulePkg/SMM: Initialize 'WillReturn' variable #1159

Closed Javagedes closed 3 weeks ago

Javagedes commented 3 weeks ago

Description

The local variable 'WillReturn' was being used without prior initialization in some code paths. This patch ensures that 'WillReturn' is properly initialized to prevent undefined behavior.

Cherry-pick from EDKII https://github.com/tianocore/edk2/commit/30b6d08e27c767ba9756a244099d73c826abcc8d Cherry-pick from dev/202405 https://github.com/microsoft/mu_basecore/commit/36f763d4f61ed9dbdb0bcc2835cca6407c8c69db

How This Was Tested

Cherry-pick from EDKII https://github.com/tianocore/edk2/commit/30b6d08e27c767ba9756a244099d73c826abcc8d

Integration Instructions

Cherry-pick from EDKII https://github.com/tianocore/edk2/commit/30b6d08e27c767ba9756a244099d73c826abcc8d

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.59%. Comparing base (85f4938) to head (07944e7).

Files with missing lines Patch % Lines
MdeModulePkg/Core/PiSmmCore/Smi.c 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202405 #1159 +/- ## ================================================== - Coverage 1.59% 1.59% -0.01% ================================================== Files 1448 1448 Lines 362500 362501 +1 Branches 5632 5632 ================================================== Hits 5776 5776 - Misses 356617 356618 +1 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1159/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.