search

microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[SQUASH ON REBASE] Fix naming convention in FirmwareVolume2 gmock #1166

Closed TsunFeng closed 2 weeks ago

TsunFeng commented 3 weeks ago

Description

Fix naming convention for FirmwareVolume2 gmock.

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.59%. Comparing base (fe6a1f9) to head (7e855a8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/202405 #1166 +/- ## =========================================== Coverage 1.59% 1.59% =========================================== Files 1448 1448 Lines 362501 362501 Branches 5632 5632 =========================================== Hits 5776 5776 Misses 356618 356618 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1166/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (ø)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.42% <ø> (ø)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (ø)` | | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (ø)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TsunFeng commented 2 weeks ago

Hi @VivianNK, Please focus this PR on modifying the mock function definitions of FvReadFile and FvWriteFile in MockFirmwareVolume2.h. I'm adding this along with the previous changes because I noticed the commit was reverted. Now that the previous changes have been restored, we can just concentrate on modifying the mock function definitions for FvReadFile and FvWriteFile. I apologize for any inconvenience this may have caused.