microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

Declare mock SMM Access2 Protocol. #1177

Open ishih1 opened 1 week ago

ishih1 commented 1 week ago

Description

Declare mock SMM Access2 Protocol for google test.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

How This Was Tested

Run the google test.

Integration Instructions

N/A

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.59%. Comparing base (dba9c25) to head (e6f80cc). Report is 1 commits behind head on dev/202405.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/202405 #1177 +/- ## =========================================== Coverage 1.59% 1.59% =========================================== Files 1448 1448 Lines 362501 362501 Branches 5632 5632 =========================================== Hits 5776 5776 Misses 356618 356618 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (ø)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.42% <ø> (ø)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (ø)` | | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (ø)` | | | [UefiCpuPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `4.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ishih1 commented 1 week ago

@ishih1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{lenovo}"]

ishih1 commented 1 week ago

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="Lenovo"

ishih1 commented 4 days ago

@VivianNK Please review this PR, thanks.

VivianNK commented 3 days ago

@VivianNK Please review this PR, thanks.

@ishih1 Hi, please create a PR to edk2 (https://github.com/tianocore/edk2) with this change

ishih1 commented 3 days ago

@VivianNK Please review this PR, thanks.

@ishih1 Hi, please create a PR to edk2 (https://github.com/tianocore/edk2) with this change

The PR has already been created. https://github.com/tianocore/edk2/pull/6299

ishih1 commented 2 days ago

@VivianNK Please approve the PR if there is no more comment.