microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[Cherry-Pick] [RB&FF] MdeModulePkg/HiiDatabaseDxe: Remove assert for VarStoreId = 0 #1185

Closed apop5 closed 2 days ago

apop5 commented 2 days ago

Description

It is legal for the VarStoreId of a question to be 0 per the UEFI spec: "Specifies the identifier of a previously declared variable store to use when storing the question’s value. A value of zero indicates no associated variable store."

Instead of hitting an assert just skip this question as there is no value to return.

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.59%. Comparing base (a45519a) to head (30e5ce4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/202405 #1185 +/- ## =========================================== Coverage 1.59% 1.59% =========================================== Files 1448 1448 Lines 362501 362501 Branches 5632 5632 =========================================== Hits 5776 5776 Misses 356618 356618 Partials 107 107 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1185/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1185/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.