microsoft / mu_basecore

Project Mu BaseCore
https://microsoft.github.io/mu/
Other
242 stars 124 forks source link

[Rebase & FF] Fix PI status code #1187

Closed kuqin12 closed 1 day ago

kuqin12 commented 1 day ago

Description

We upstreamed the correct PI status code to PI spec and should get rid of MU_CHANGE to avoid conflict.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

How This Was Tested

This change only involves definition migration.

Integration Instructions

For applicable components, platform needs to update these definitions in their code.

EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE -> EFI_SW_EC_ILLEGAL_SOFTWARE_STATE EFI_SW_EC_RELEASE_ASSERT -> EFI_SW_EC_ILLEGAL_SOFTWARE_STATE

codecov-commenter commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.35%. Comparing base (8b26fc4) to head (112c92a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/202311 #1187 +/- ## =============================================== Coverage 1.35% 1.35% =============================================== Files 1303 1303 Lines 333839 333839 Branches 5103 5103 =============================================== Hits 4512 4512 Misses 329244 329244 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1187/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MdeModulePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.68% <ø> (ø)` | | | [MdePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `5.40% <ø> (ø)` | | | [NetworkPkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.55% <ø> (ø)` | | | [PolicyServicePkg](https://app.codecov.io/gh/microsoft/mu_basecore/pull/1187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `30.41% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

apop5 commented 1 day ago

This is back porting these changes into the 202311 branch.

Is there a benefit to bringing this back when 202405 has changed this?

Also, if this is going into 202311, do the (two?) places where these MU defines were used need to be changed in their respective 202311 branches as well?

kuqin12 commented 1 day ago

This is back porting these changes into the 202311 branch.

Is there a benefit to bringing this back when 202405 has changed this?

yeah, the addition of these definitions after updating the spec is a mistake in the first place. The consumers are still using these proprietary definitions, which is making the pipeline receiving mixed value for the same events.