Closed kuqin12 closed 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 1.35%. Comparing base (
8b26fc4
) to head (112c92a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is back porting these changes into the 202311 branch.
Is there a benefit to bringing this back when 202405 has changed this?
Also, if this is going into 202311, do the (two?) places where these MU defines were used need to be changed in their respective 202311 branches as well?
This is back porting these changes into the 202311 branch.
Is there a benefit to bringing this back when 202405 has changed this?
yeah, the addition of these definitions after updating the spec is a mistake in the first place. The consumers are still using these proprietary definitions, which is making the pipeline receiving mixed value for the same events.
Description
We upstreamed the correct PI status code to PI spec and should get rid of MU_CHANGE to avoid conflict.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This change only involves definition migration.
Integration Instructions
For applicable components, platform needs to update these definitions in their code.
EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE
->EFI_SW_EC_ILLEGAL_SOFTWARE_STATE
EFI_SW_EC_RELEASE_ASSERT
->EFI_SW_EC_ILLEGAL_SOFTWARE_STATE