search

microsoft / mu_devops

Project Mu Developer Operations
https://microsoft.github.io/mu/
Other
26 stars 22 forks source link

Re-introduce workaround to fix ADO path names for PR eval #112

Closed cfernald closed 1 year ago

cfernald commented 1 year ago

Adds a work-around to the naming provided by System.PullRequest.targetBranch on ADO repos by stripping the refs/heads/ from the path since that makes it unrecognizable to git for the git diff used by stuart_pr_eval.

cfernald commented 1 year ago

I have been defeated by azure pipeline expressions. I attempted to do this inline in existing step, but could not get the combination of the replace expression with the pre-defined system variable to function properly. If anyone has any ideas on this please let me know.

makubacki commented 1 year ago

@cfernald what about the instance in https://github.com/microsoft/mu_devops/blob/main/Steps/BuildPlatform.yml#L84?

cfernald commented 1 year ago

@cfernald what about the instance in https://github.com/microsoft/mu_devops/blob/main/Steps/BuildPlatform.yml#L84?

good point, will fix there as well